Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing env. var. secrets #1834

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fix: add missing env. var. secrets #1834

merged 1 commit into from
Apr 3, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Apr 3, 2023

What it solves

Missing env. vars. in workflow.

How this PR fixes it

All env. vars. mentioned in the readme are now added in the build workflow (gateway URLs and Safe version).

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh April 3, 2023 09:47
@iamacook iamacook self-assigned this Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023 •
edited
Loading

Branch preview

✅ Deploy successful!

https://secrets--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@iamacook
Copy link
Member Author

iamacook commented Apr 3, 2023 •
edited
Loading

I'm going to merge this directly as it is build-related.

@iamacook iamacook merged commit ae5d4d8 into dev Apr 3, 2023
@iamacook iamacook deleted the secrets branch April 3, 2023 09:56
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katspaugh katspaugh katspaugh approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
Web Squad
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamacook @katspaugh